Metal Pool 1D Kernel #16429
Open
Metal Pool 1D Kernel #16429
+205
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ggml
ggerganov
reviewed
Oct 6, 2025
Member
ggerganov
left a comment
ggerganov
left a comment
There was a problem hiding this comment.
- Need to add tests
- The implementation assumes contiguous data - either require this to be true, or extend the implementation to support non-cont data
| int np; | ||
| int k0; | ||
| int s0; | ||
| int p0; |
Member
There was a problem hiding this comment.
The order of the arguments does not match the initialization in ggml-metal-ops.cpp.
Also, some of these arguments like np need to be 64-bit integers.
Author
There was a problem hiding this comment.
Thanks. It's resolved and added tests for 1D pooling in ./test-backend-ops which should now pass for cpu and metal
This comment was marked as spam.
This comment was marked as spam.
Author
|
@ggerganov I added tests for 1D pooling in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Metal backend support for
POOL_1Doperators.Until now, only the
POOL_2Dwas implemented for Metal.With this change, models relying on 1D pooling can now run fully accelerated on Apple GPUs through Metal in an analog way.
Implementation Details
Added new Metal compute kernels in
ggml-metal.metal:kernel_pool_1d_max_f32kernel_pool_1d_avg_f32Implemented
ggml_metal_op_pool_1danalogous toggml_metal_op_pool_2d, including:ggml_metal_kargs_pool_1d)x